Hotfix gradient with cache intermediates #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If calling
infidelity
and theninfidelity_derivative
, the control matrix is cached during the first call, but not the intermediates. This leads to an exception whengradient.calculate_control_matrix_derivative_from_scratch()
tries to access the intermediates (sincePulseSequence.get_filter_function_derivative()
passes them along).