Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concatenation with zero n_coeffs #59

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

thangleiter
Copy link
Member

Instead of populating a zeros array, populate a nan array and check for those.

Instead of populating a zeros array, populate a nan array and check for those.
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #59 (64d01da) into master (dc1ccd2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files           9        9           
  Lines        2203     2203           
  Branches      499      498    -1     
=======================================
  Hits         2143     2143           
  Misses         26       26           
  Partials       34       34           
Impacted Files Coverage Δ
filter_functions/pulse_sequence.py 97.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1ccd2...64d01da. Read the comment docs.

@thangleiter thangleiter merged commit e368ad6 into master Mar 11, 2021
@thangleiter thangleiter deleted the hotfix/concatenation_with_zero_n_coeffs branch March 11, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant