Small improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faster for all but d=2 and more consistent now
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 97.13% 97.28% +0.14%
==========================================
Files 9 9
Lines 2237 2247 +10
Branches 503 509 +6
==========================================
+ Hits 2173 2186 +13
+ Misses 30 28 -2
+ Partials 34 33 -1
Continue to review full report at Codecov.
|
Also add kwarg to circumvent invertibility check. Most often reasonable results occur with linalg.solve() even when the determinant is zero, and checking for invertibility is quite expensive (so is explicitly evaluating the sum)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small improvements.