Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __len__ and __getitem__ methods to PulseSequence #67

Merged
merged 6 commits into from
May 12, 2021

Conversation

thangleiter
Copy link
Member

This allows for things like

for seg in pulse_sequence:
    do_something_with(seg)

and hence easily investigate parts (time slices) of sequences.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #67 (d43e184) into master (8bf6159) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   97.30%   97.31%           
=======================================
  Files           9        9           
  Lines        2229     2237    +8     
  Branches      502      503    +1     
=======================================
+ Hits         2169     2177    +8     
  Misses         26       26           
  Partials       34       34           
Impacted Files Coverage Δ
filter_functions/pulse_sequence.py 97.66% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf6159...d43e184. Read the comment docs.

@thangleiter thangleiter merged commit df0e553 into master May 12, 2021
@thangleiter thangleiter deleted the feature/len_and_getitem branch May 12, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant