Comply with new upstream API #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thangleiter
changed the title
Otherwise we cannot use them for the calculation of the gradients
Included and to be discussed in qopt/pull/8
|
I merged the small fixes first. There seems to be a conflict in the new verbose parameter. Could you merge these branches easily in your local repo? |
|
@JDTeske done, tests run through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qutech/filter_functions#53 changes two parameter names to be more consistent with the rest of the package. This PR should hopefully cover all changes.
@JDTeske, will the renaming of
qoptinternal parameters likesolver.filter_function_s_derivs-->solver.filter_function_n_coeffs_derivbreak anything I did not catch?I also fixed some docstring that looks like it was copied over from
filter_functionsand wasn't accurate anymore.