Simplify pulse sequence instantiation #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the optimizer only updates the control amplitudes of the solver object. In that case it's much simpler to just manually set the new amplitudes if a
solver.pulse_sequence
already exists. When updating, we just need to make sure to clear all cached attributes (like the eigendecomposition) of thePulseSequence
object.Furthermore, the
PulseSequence
constructor can handleqopt.DenseOperator
s and the instantiation of the object insolver.create_pulse_sequence()
can be simplified a bit (once qutech/filter_functions#53 is merged).With these changes,
solver.plot_bloch_sphere
can also be a bit leaner and just call thesolver.create_pulse_sequence()
method.