Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: gRPC instrument #4

Merged
merged 5 commits into from
Jan 4, 2024
Merged

feature: gRPC instrument #4

merged 5 commits into from
Jan 4, 2024

Conversation

jiekun
Copy link
Member

@jiekun jiekun commented Jan 4, 2024

Added

  • gRPC instrument.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (b512e87) 89.70% compared to head (c826e6d) 87.61%.

Files Patch % Lines
metrics/grpc/grpc.go 86.57% 15 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   89.70%   87.61%   -2.10%     
==========================================
  Files           3        4       +1     
  Lines          68      218     +150     
==========================================
+ Hits           61      191     +130     
- Misses          5       20      +15     
- Partials        2        7       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiekun jiekun merged commit 7ffc1a9 into master Jan 4, 2024
3 checks passed
@jiekun jiekun deleted the feature/grpc branch January 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant