Added game history viewer feature #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added optional flag parameter to updateGameState method to configure whether the fen should be updated (so that in cases when the fen doesn't need to be updated or the new fen is already known, the new fen does not need to be unnecessarily calculated and updated). - Changed move method to only update the board position when neccessary (ie. in the event of a promotion or en passant capture). - Moved move and promotion emits into the move method as these are the only times they should ever be emitted. This means the last move isn't unnecessarily found every time emitEvents is called. - Fixed broken putPiece method (previously only added the piece to the chess.js game and did not update the chessground board). - Fixed patching of changeTurn to movable.events.after in the event user tries to set it to undefined (previously the BoardApi object was not getting bound to the method, causing an error).
Feature includes several associated methods: - viewHistory to view the position at a specific ply - stopViewingHistory to return to the present position - viewStart to view the starting position - viewNext to view the next move when viewing history - viewPrevious to view the previous move
qwerty084
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewHistoryto view the position at a specific plystopViewingHistoryto return to the present positionviewStartto view the starting positionviewNextto view the next move when viewing historyviewPreviousto view the previous move