添加自定义字幕后缀 #55
Merged
添加自定义字幕后缀 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `CustomLangExt` property in Config.cs - Updated RenameService to handle custom language extensions - Modified SettingsViewModel to include custom language extension logic - Enhanced SettingsWindow to allow user input for custom language extensions - Ensured mutual exclusivity between keeping language extension and custom language extension options
|
谢谢提交 PR，我改了下代码，实现了 “保留语言后缀” 选项和 “添加字幕后缀” 的互斥，互斥的原因是：保留了语言后缀将从原始字幕文件名里面提取，而不是使用自定义添加的字幕后缀，反之则反。 另外，这个 “保留语言后缀” 似乎不需要和 “备份原始字幕” 互斥？🤔 互斥的原因是什么？ |
This was
linked to
issues
Sep 23, 2024
Closed
Closed
感谢修改！我才发现自己打错了😂，应该是“保留语言后缀” 选项和 “添加字幕后缀” 的互斥。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
尝试增加了针对#40 提出的issue增加了手动添加自定义字幕后缀的功能
不过有个不太优雅的地方就是
保留语言后缀和备份原始字幕应该互斥，比如选择了保留语言后缀后备份原始字幕应该处于无法修改的状态，不知道AvaloniaUI有没有类似的功能。