refactor: optimize Matcher algorithm #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR included:
Separation of Concerns
MatchItem
from theSubRenamer.Model
namespace in the view layer.Execute
function, the view layer'sMatchItem
is converted to the algorithm layer'sMatchItem
usingMatcherDataConverter.ConvertMatchItems
. After execution, the returnedMatchItem
is converted back to the view layer's format.Use of Records:
MatchItem
andDiffResult
data structures. This change emphasizes immutability, making testing easier.Function Behavior:
List
in place. Instead, they return a newList
copy. The input is defined as an immutableIReadOnlyList
, promoting idempotency and simplifying testing.Diff Result Calculation:
GetDiffResult
method has been modified to use a double loop, wherei
andj
approach from both ends towards the center. It prioritizes matching the first and last items instead of adjacent ones. This aims to prevent incorrectDiffResult
prefixes and suffixes when multiple identical filenames in different languages are encountered.Improvements to FindCommonSuffix:
Prefix
has been removed fromFindCommonSuffix
.Type and Variable Modifications: