Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MIX message, presence and roster extensions #175

Merged
merged 5 commits into from
May 1, 2019
Merged

Implement MIX message, presence and roster extensions #175

merged 5 commits into from
May 1, 2019

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Jan 5, 2019

No description provided.

@lnjX lnjX force-pushed the feature/mix-message-presence branch from e569ed3 to 1bfbe65 Compare January 5, 2019 13:23
@codecov
Copy link

codecov bot commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #175 into master will increase coverage by 0.23%.
The diff coverage is 91.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   65.88%   66.12%   +0.23%     
==========================================
  Files         148      147       -1     
  Lines       14849    14962     +113     
==========================================
+ Hits         9783     9893     +110     
- Misses       5066     5069       +3
Impacted Files Coverage Δ
tests/qxmpppresence/tst_qxmpppresence.cpp 100% <100%> (ø) ⬆️
src/base/QXmppMessage.cpp 88.99% <100%> (+0.64%) ⬆️
tests/qxmppmessage/tst_qxmppmessage.cpp 100% <100%> (ø) ⬆️
tests/qxmpprosteriq/tst_qxmpprosteriq.cpp 100% <100%> (ø) ⬆️
src/base/QXmppPresence.cpp 85.85% <100%> (+1.44%) ⬆️
src/base/QXmppRosterIq.cpp 80.91% <82.35%> (+4.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df7e7f...e63698c. Read the comment docs.

@lnjX lnjX mentioned this pull request Jan 5, 2019
Closed
5 tasks
@lnjX lnjX force-pushed the feature/mix-message-presence branch from 1bfbe65 to 36cc8e9 Compare January 19, 2019 14:52
jlaine
jlaine reviewed Jan 20, 2019
View reviewed changes
src/base/QXmppRosterIq.cpp Outdated Show resolved Hide resolved
@lnjX lnjX force-pushed the feature/mix-message-presence branch from 36cc8e9 to b0642a4 Compare January 20, 2019 21:35
jlaine
jlaine reviewed Jan 21, 2019
View reviewed changes
src/base/QXmppRosterIq.h Outdated Show resolved Hide resolved
jlaine
jlaine reviewed Jan 21, 2019
View reviewed changes
src/base/QXmppRosterIq.h Outdated Show resolved Hide resolved
@lnjX lnjX force-pushed the feature/mix-message-presence branch from b0642a4 to 229402a Compare March 9, 2019 11:55
@lnjX lnjX mentioned this pull request Mar 9, 2019
Closed
@lnjX
Copy link
Member Author

lnjX commented Apr 16, 2019

If the ABI break is a problem for you, you could maybe merge everything into a new develop branch or something like this.

@tehnick
Copy link
Member

tehnick commented Apr 16, 2019

I do not think that ABI breaks may be a problem for now. Because we only at the beginning of a way of introducing the practice of maintaining of stable ABI in qxmpp.

@lnjX
Copy link
Member Author

lnjX commented Apr 16, 2019

Is there anything because this pull request can't be merged?

@lnjX
Copy link
Member Author

lnjX commented Apr 25, 2019

@jlaine Please come back from your reviewing holidays :)

lnjX added 3 commits April 30, 2019 21:00
@lnjX
Implement MIX-CORE XEP-0396: Message extension
1448ef2 
This implements the new message extension specified by XEP-0369: Mediated
Information eXchange (MIX) in version 0.14.2.

https://xmpp.org/extensions/xep-0369.html#usecase-user-message
@lnjX
Implement MIX-PAM XEP-0405: Presence extension
5c0485d 
This implements the new presence extension defined by XEP-0405: Mediated
Information eXchange (MIX): Participant Server Requirements in version
0.4.0.

https://xmpp.org/extensions/xep-0405.html#usecase-user-presence-receive
@lnjX
Implement MIX-PAM XEP-0405: Roster IQ extension
e63698c 
This adds the MIX extensions for roster queries as defined in XEP-0405:
Mediated Information eXchange (MIX): Participant Server Requirements in
version 0.4.0.

https://xmpp.org/extensions/xep-0405.html#mix-roster-capability-sharing
@lnjX lnjX force-pushed the feature/mix-message-presence branch from 229402a to e63698c Compare April 30, 2019 19:04
@lnjX
Copy link
Member Author

lnjX commented Apr 30, 2019

Updated implementation to latest XEP version.

jlaine
jlaine reviewed May 1, 2019
View reviewed changes
CMakeLists.txt
@@ -5,7 +5,7 @@ cmake_minimum_required(VERSION 3.2)
set(VERSION_MAJOR 1)
set(VERSION_MINOR 0)
set(VERSION_PATCH 1)
set(SO_VERSION 1)
set(SO_VERSION 2)
Copy link
Contributor

@jlaine jlaine May 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unrelated to this PR.

Update: ah shit, roster IQ ABI changed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the problem.

@jlaine jlaine merged commit 740a085 into qxmpp-project:master May 1, 2019
@jlaine
Copy link
Contributor

jlaine commented May 1, 2019

@jlaine Please come back from your reviewing holidays :)

I wish someone else would take part in the review process.. It's a bit daunting when there are 20 PRs to review!

@lnjX
Copy link
Member Author

lnjX commented May 1, 2019

@jlaine Thanks for merging! :)

I wish someone else would take part in the review process.. It's a bit daunting when there are 20 PRs to review!

I'd like to do so, but I also can't review my own pull requests.

@lnjX lnjX deleted the feature/mix-message-presence branch May 1, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaine jlaine jlaine left review comments

@tehnick tehnick tehnick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lnjX @tehnick @jlaine