-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qz-tray-console.exe for debugging purposes #828
Conversation
When I call the console from This seems to work as expected. I tried printing some HTML with Is there anything specific I should test before approving? |
Good point. Yeah, I hadn't thought about that. If you look at the commit, it's just a small trick that replaces The memory shelf should be identical to the normal launcher, because it's a copy of it (clones it at compile time, replaces the The new console can be avoided using some NSIS tricks but it's a hack, so I opted for the simplest solution, which was to just leverage the console version of Java. The reason this happens is because in Windows, you can't have a GUI app and a console app in the same exe and NSIS is a GUI app only unless the NSIS source is recompiled. The hacks include attaching to a console and writing output, but it would be harder to re-use code and may be less reliable.
I can't think of any. |
The only problem I see with this behavior is the console closes automatically when the app is no longer running. So if there's a hard crash to QZ Tray, the stack trace containing the error will be lost. If there's a hard-crash we're trying to debug on Windows, we'll have to use the old method for launching QZ Tray via the console. |
Right, and the old method is growing increasingly difficult. I'll see what I can whip up. |
I tested this and it works 👍. Approving. |
Supersedes #801