chore: Windows: update to libpq-15.3 #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroen
force-pushed
the
winlibs
branch
2 times, most recently
from
6a02e61 to
6c995a6
Compare
|
I think this is good to merge. The Windows compiler warning is pre-existing and is triggered by your vendored boost, and is unrelated to this PR: Found the following significant warnings:
vendor/boost/intrusive/detail/slist_node.hpp:56:16: warning: pointer used after 'void operator delete(void*, std::size_t)' [-Wuse-after-free]
vendor/boost/intrusive/detail/hook_traits.hpp:77:10: warning: pointer used after 'void operator delete(void*, std::size_t)' [-Wuse-after-free] |
|
Good catch regarding this warning. Is this a g++12 bug? I could update the vendored headers to see if it goes away, but I wonder if an Rtools update is pending that will upgrade GCC. |
krlmlr
changed the title
|
Thanks. It's great to have these warnings appear in CI/CD too 😊 . The same warnings are seen on CRAN, so perhaps not worth holding our breath. |
|
Yes I think it is a bug in gcc-12. It is fixed in gcc-13. I can suggest a hack if you like. |
|
A hack would be great, thanks! |
|
OK here you go: #443 |
krlmlr
added a commit
that referenced
this pull request
Mar 31, 2024
RPostgres 1.4.6 - Breaking change: `dbListObjects()` only allows `Id()` objects as `prefix` argument (@dpprdan, #390). - Use `NULL` in favor of `NULL::text` when quoting strings and literals, to support JSON and other text-ish types. Fixes a regression introduced in #370 (#393, #425). - `dbQuoteLiteral()` correctly quotes 64-bit integers from the bit64 package (of class `"integer64"`) (@karawoo, #435, #436). - Breaking change: `dbListObjects()` only allows `Id()` objects as `prefix` argument (@dpprdan, #390). - Windows: update to libpq-15.3 (#442). - Upgrade boost to 1.81.0-1 to fix sprintf warnings (#417). - Suppress warning in gcc-12 (#443). - Tweak driver docs (@dpprdan, #433). - Relicense as MIT. - Close result set. - Replace Rcpp by cpp11 (@Antonov548, #419).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds support for ARM, which CRAN is going to support soon.