Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Type: BIGNUMERIC support #435

Closed
eduardodrc opened this issue Mar 1, 2021 · 9 comments · Fixed by #581
Closed

Data Type: BIGNUMERIC support #435

eduardodrc opened this issue Mar 1, 2021 · 9 comments · Fixed by #581
Labels
download ⬇️ feature a feature request or enhancement

Comments

@eduardodrc
Copy link

There is a new decimal type BIGNUMERIC available for Big Query tables (see data types docs). When we load a table with this type, we receive the error message:

Running job 'example' [\]  1s
Complete
Billed: XX.XX MB
Downloading Y rows in Z pages.
Error in bq_parse_files(schema_path, page_paths, n = page_info$n_rows,  :                              
  Unknown type BIGNUMERIC

I think that we can just map BIGNUMERIC to float type (Rcpp::DoubleVector), but I'm not a master here. A similar request in the python SDK can help python-bigquery/ issue 367.

Thank you for the great work!

@dylanrussellmd

This comment was marked as outdated.

@hadley

This comment was marked as outdated.

@kieran-mace

This comment was marked as outdated.

@thomassie

This comment was marked as outdated.

@hadley

This comment was marked as outdated.

@thomassie

This comment was marked as outdated.

@hadley

This comment was marked as outdated.

@hadley hadley added feature a feature request or enhancement api 🕸️ labels Nov 3, 2023
@hadley
Copy link
Member

hadley commented Nov 3, 2023

I'd very much appreciate it if anyone could make me a reprex for this issue, i.e. some code that created a table with a BIGNUMERIC field and then tried to download from it. That would save me a little time and allow me to fix the underlying problem a little bit faster.

@hadley
Copy link
Member

hadley commented Nov 9, 2023

I think the easiest thing to do (which I'll do for all unknown types) is to just return the string data, so you can do what you will with it.

hadley added a commit that referenced this issue Nov 9, 2023
* Parse dates, datetimes, and times in R with the clock package. Fixes #285. Fixes #430
* Return all other unknown types as strings. Fixes #435. Fixes #544.
hadley added a commit that referenced this issue Nov 10, 2023
* Parse dates, datetimes, and times in R with the clock package. Fixes #285. Fixes #430
* Return all other unknown types as strings. Fixes #435. Fixes #544.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
download ⬇️ feature a feature request or enhancement
Projects
None yet
5 participants