Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DBI scanning through entity handler options instead of specific handlers #386

Closed
eblondel opened this issue May 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request software:dbi Data Base Interfacing software:ocs OCS clouds (owncloud, nextcloud, etc)
Milestone

Comments

@eblondel
Copy link
Collaborator

eblondel commented May 13, 2024

With the support of handler options (see #346), there is no need to use specific designed handlers like the one developed in #347 for DBI scanning:

  • Handlers dbi_csv, dbi_gsheet, dbi_excel will be deprecated (with addition of active/deprecated status and associates notes to characterize handlers).
  • Handlers csv, gsheet, excel will be enriched with an option enrich_from_dbi that will support the same DBI scanning logic.

In addition the ocs handler will have the same enrich_from_dbi option. This will enable to use CSV/Excel entities stored in OCS with DB scanning.

@eblondel eblondel added the enhancement New feature or request label May 13, 2024
@eblondel eblondel added this to the 1.0 milestone May 13, 2024
@eblondel eblondel self-assigned this May 13, 2024
eblondel added a commit that referenced this issue May 13, 2024
@wheintz
Copy link
Contributor

wheintz commented May 14, 2024

Hi @eblondel ,
I just tried this new functionality of handler enrichment, but it sends an error (with or without the option, using handler OCS):
Erreur dans handle_entities_csv(config = config, source = entities_file, : l'argument "handler" est manquant, avec aucune valeur par défaut
Thanks!

@eblondel
Copy link
Collaborator Author

This error let think geoflow has not been reinstalled correctly, as this shows old code
Try to restart R and reinstall geoflow.

@eblondel eblondel added software:ocs OCS clouds (owncloud, nextcloud, etc) software:dbi Data Base Interfacing labels May 14, 2024
@wheintz
Copy link
Contributor

wheintz commented May 14, 2024

Thank you @eblondel ,
Indeed I had to restart my R session... Now everything is OK!
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request software:dbi Data Base Interfacing software:ocs OCS clouds (owncloud, nextcloud, etc)
Projects
None yet
Development

No branches or pull requests

2 participants