Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working-directory input to check-r-package #444

Closed
wants to merge 16 commits into from
Closed

Add working-directory input to check-r-package #444

wants to merge 16 commits into from

Conversation

TNonet
Copy link
Contributor

@TNonet TNonet commented Nov 24, 2021

This is an extension to #438 based on a request from @riccardoporreca.

I believe this PR is self explanatory. Working on checking these changes on my repo.

Looking for comments and feedback.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #444 (52ff960) into master (2049ddf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #444   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2049ddf...52ff960. Read the comment docs.

runs:
using: "composite"
defaults:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just call rcmdcheck::rcmdcheck(path = ${{ inputs.working-directory }}?

@jimhester
Copy link
Member

Assuming you have r-lib/actions set as your upstream remote if you run

git fetch upstream
git rebase upstream/master
git push --force-with-lease

On your local repo it should remove the older commits from this PR.

@TNonet
Copy link
Contributor Author

TNonet commented Nov 24, 2021

@jimhester, I am going to close this PR and open another PR once I remove the old commits. I somehow got myself in a bad git state.

@TNonet TNonet closed this Nov 24, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants