-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add working-directory
input to check-r-package
#444
Conversation
We had duplication due to a rebase
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 Continue to review full report at Codecov.
|
runs: | ||
using: "composite" | ||
defaults: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just call rcmdcheck::rcmdcheck(path = ${{ inputs.working-directory }}
?
Assuming you have git fetch upstream
git rebase upstream/master
git push --force-with-lease On your local repo it should remove the older commits from this PR. |
@jimhester, I am going to close this PR and open another PR once I remove the old commits. I somehow got myself in a bad git state. |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
This is an extension to #438 based on a request from @riccardoporreca.
I believe this PR is self explanatory. Working on checking these changes on my repo.
Looking for comments and feedback.