Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codecov token in test coverage #823

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add codecov token in test coverage #823

merged 4 commits into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. fix: add CODEDOV_TOKEN in test-coverage workflow 

    - To be able to upload the code coverage result to codecov.io users must now provide a CODECOV_TOKEN to authenticate to the service.
- This token must be defined as a repository secret.
- GITHUB_PAT is no longer required for the workflow to work
    @ALanguillaume
    ALanguillaume authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    232d51b View commit details
    Browse the repository at this point in the history

  2. fix: explicitely pass CODECOV_TOKEN as covr::codecov() parameter 

    - Make the intent of the token explicit.
- That way readers can clearly see that CODECOV_TOKEN in a requirement for `covr::codecov()`.
    @ALanguillaume
    ALanguillaume authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4f2a4d7 View commit details
    Browse the repository at this point in the history

  3. Revert "fix: explicitely pass CODECOV_TOKEN as covr::codecov() parame… 

    …ter"

This reverts commit 4f2a4d7.
    @ALanguillaume
    ALanguillaume committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b0761e0 View commit details
    Browse the repository at this point in the history

  4. fix: include back GITHUB_PAT in test-coverage 

    Some packages need that to install dependencies from github for example
    @ALanguillaume
    ALanguillaume committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    167d437 View commit details
    Browse the repository at this point in the history