Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cpp11::messages with opt-in fmt formatting #213

Merged
merged 24 commits into from
Jul 23, 2021

Conversation

sbearrows
Copy link
Contributor

Fixes #208

Let me know what you think!

@sbearrows sbearrows requested a review from jimhester July 23, 2021 17:56
@sbearrows
Copy link
Contributor Author

sbearrows commented Jul 23, 2021

I had a bunch of merge conflicts so I'm not surprised that format_check is failing. I'm gonna wait to see if the other checks pass and then I'l fix it!

Well that was a fail.

@jimhester
Copy link
Member

could you rebase this branch on the current master? I can help you do it in our meeting if you need to, but assuming r-lib/master is the 'upstream' remote you would do something like.

git checkout feature-message_fmt
git fetch upstream
git rebase upstream/master

I think your branch is based on your forks master branch, which is very out of date at this point, so we are getting a bunch of extra commits in the PR.

@sbearrows
Copy link
Contributor Author

Yes, please and thank you!

@jimhester jimhester merged commit e51bcce into r-lib:master Jul 23, 2021
@jimhester
Copy link
Member

Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cpp11::message()
2 participants