discard messages when keep_message = FALSE, and warnings when keep_wa…

…rning = FALSE (yihui/knitr#1880 (comment))
r-lib · Nov 21, 2022 · 5e8fc32 · 5e8fc32
1 parent bb87476
commit 5e8fc32
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: evaluate
 Type: Package
 Title: Parsing and Evaluation Tools that Provide More Details than the Default
-Version: 0.18.1
+Version: 0.18.2
 Authors@R: c(
     person("Hadley", "Wickham", role = "aut"),
     person("Yihui", "Xie", role = c("aut", "cre"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,8 @@
 Version 0.19
 ================================================================================
 
+- In `evaluate()`, `keep_message` and `keep_warning` will completely drop messages and warnings, respectively, when their values are `FALSE`. Previously messages would still be emitted (to the console) even if they take `FALSE` values.
+
 Version 0.18
 ================================================================================
 

diff --git a/R/eval.r b/R/eval.r
@@ -156,7 +156,7 @@ evaluate_call <- function(call, src = NULL,
       output_handler$warning(wn)
     }
     invokeRestart("muffleWarning")
-  } else identity
+  } else function() {}
   eHandler <- if (use_try) function(e) {
     handle_condition(e)
     output_handler$error(e)
@@ -165,7 +165,7 @@ evaluate_call <- function(call, src = NULL,
     handle_condition(m)
     output_handler$message(m)
     invokeRestart("muffleMessage")
-  } else identity
+  } else function() {}
 
   ev <- list(value = NULL, visible = FALSE)