Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress #26

Closed
jennybc opened this issue Dec 17, 2015 · 4 comments · Fixed by #100
Closed

progress #26

jennybc opened this issue Dec 17, 2015 · 4 comments · Fixed by #100
Labels
feature a feature request or enhancement

Comments

@jennybc
Copy link
Member

jennybc commented Dec 17, 2015

Is it feasible for gh to indicate progress?

@gaborcsardi
Copy link
Member

When making multiple rounds of queries? I guess a single query is always fast.

@jennybc
Copy link
Member Author

jennybc commented Dec 17, 2015

I'm making some queries now that retrieve thousands of items and take several minutes. It would be comforting to have some sense of progress.

I guess I actually know from using the API directly how easy (or, annoying, rather) it is to learn the total number of items available.

What do you think of showing progress, perhaps only when .limit = Inf?

@gaborcsardi
Copy link
Member

Yeah, whenever .limit is bigger than 30 we can do it I guess. For the .limit = Inf case when there is a rel="last" link we can do a proper progress bar, without that we can only do a counter that shows how many queries have completed.

@gaborcsardi
Copy link
Member

I am rewriting https://github.com/gaborcsardi/progress, again. And it will be awesome, of course. Once that is done, I'll get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants