Merge pull request #252 from jeroenooms/progress

Fix for default progress function
r-lib · Jun 26, 2015 · d9395f2 · d9395f2
2 parents d2b05be + ab77c9b
commit d9395f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # httr 1.0.0.9000
 
+* fix for 'progress callback must return boolean' warning
+
 # httr 1.0.0
 
 * httr no longer uses the RCurl package. Instead it uses the curl package, 

diff --git a/R/progress.R b/R/progress.R
@@ -36,7 +36,7 @@ progress_bar <- function(type) {
     if (total == 0 && now == 0) {
       bar <<- NULL
       first <<- TRUE
-      return()
+      return(TRUE)
     }
 
     if (total == 0) {
@@ -53,7 +53,7 @@ progress_bar <- function(type) {
       setTxtProgressBar(bar, now)
     }
 
-    0L
+    TRUE
   }
 
   show_progress