Add option to retrieve oauth2.0 token using basic authentication #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' @export | ||
| #' @keywords internal | ||
| init_oauth2.0 <- function(endpoint, app, scope = NULL, type = NULL, | ||
| use_oob = getOption("httr_oob_default"), | ||
| is_interactive = interactive()) { | ||
| is_interactive = interactive(), | ||
| use_basic_auth = NULL) { |
There was a problem hiding this comment.
It would be more clear to make the default value FALSE
|
Looks good, apart from a few minor comments. Could you please also a bullet to NEWS? |
| code = code)) | ||
| # Send credentials using HTTP Basic or as parameters in the request body | ||
| # See https://tools.ietf.org/html/rfc6749#section-2.3 (Client Authentication) | ||
| if (isTRUE(use_basic_auth)){ |
There was a problem hiding this comment.
It feels like there's a little too much duplication here. Could you please pull out the common body?
|
I've pulled out the common body now, thanks. I've also moved the NEWS bullet to the top. I hope the commits are okay - I'm a novice at collaboration on github. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #288 this adds an option to
oauth2.0_tokenso that when the authorization code is exchanged for the token it can be done using http basic authentication, rather than the default method of including the app key and secret in the request body.From the OAuth2.0 Framework RFC it looks like authorization servers should provide the http basic authentication method as a minimum, and the method of providing the app key/secret in the request body is optional. I see that the github api allows both, but fitbit only allows basic authentication.