Add option user_params to oauth2.0_token to enable endpoint-specific access parameters. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als. Rd files have not yet been created and tests have not been run.
… pass additional parameters during token access or refresh as required by endpoints like Azure AD.
| redirect_uri = redirect_uri, | ||
| grant_type = "authorization_code", | ||
| code = code)) | ||
| req_params <- c( |
There was a problem hiding this comment.
I think it would be slightly better to use stats::modifyList() and change the order of the argument so that user_params "loses" if a name is defined in both places.
|
Apart from a couple of minor things, looks good. Could you please also add a bullet point to NEWS? |
|
Thanks for your comments. I added the news bullet and modified the code according to your notes. |
hadley
added a commit
that referenced
this pull request
Jan 7, 2016
Add option user_params to oauth2.0_token to enable endpoint-specific access parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch holds the implementation for passing additional access parameters in the form of a list of named values to the oauth2.0_token function. The function refresh_oauth2.0 was modified accordingly.
The service account functionality was not touched. My only reference for the use of user_params, Microsoft Azure AD, uses quite different parameters for service-to-service authorization when compared to httr's init_oauth_service_account. See https://msdn.microsoft.com/en-us/library/azure/dn645543.aspx.
A demo for the Azure AD endpoint was added. In the committed version it uses dummy credentials and will run but not succeed.
While viewing the diffs on github, I noticed a possible typo in the demo/00Index line
"oauth2-linkedin Using linkedin api with OAuth 1.0" which probably should read "OAuth 2.0".