fix oauth_encode() #424
Merged
fix oauth_encode() #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yutannihilation Thanks alot 🥇 you saved me |
|
@Crackz Oh, I'm glad to hear that 😄 Actually, I've noticed this bug when I was trying rtweet... |
|
But, I'm a bit afraid httr may be no more maintained since I see no responses to the issues and PRs since half a years ago. Hmm... |
|
Ah, I got it. Hadley says this five months ago:
|
|
I hope it come soon ... |
|
Agreed. |
hadley
reviewed
Jul 24, 2017
tests/testthat/test-oauth.R
Outdated
| restored_string <- URLdecode(oauth_encode1(orig_string)) | ||
| Encoding(restored_string) <- "UTF-8" | ||
|
|
||
| expect_equal( |
There was a problem hiding this comment.
Can you please put this on one line?
yutannihilation
force-pushed
the
fix-encode
branch
from
a38c24b
to
ff173af
Compare
|
Thanks! Updated NEWS and test. |
|
Thanks! |
|
Thanks for merging! This bug was a bit annoying, so I'm very happy to see this closed! 🍺 |
jiwalker-usgs
pushed a commit
to jiwalker-usgs/httr
that referenced
this pull request
Jul 24, 2017
* fix oauth_encode() * update test * update NEWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #423.
The problem is in this part of
oauth_encode1():This seems to expect the result of
charToRaw(x)is a single character, but this assumption fails whenxis a UTF-8 character:Therefore, the following line doesn't work well:
As the length of the left hand side is smaller than the right hand side, some bytes at the tail is lost when assigning. That's what this warning says.
This pull request adds
collapse = ""so thatencode()returns a single character vector.