Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digest package missing when using package with url:: syntax #433

Closed
krlmlr opened this issue Nov 24, 2022 · 2 comments
Closed

digest package missing when using package with url:: syntax #433

krlmlr opened this issue Nov 24, 2022 · 2 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 24, 2022

https://github.com/tidyverse/dplyr/actions/runs/3542720296/jobs/5948511287#step:5:129

Dependency resolution
  ℹ Creating lockfile '.github/pkg.lock'
  ✖ Creating lockfile '.github/pkg.lock' [237ms]
  
  Error: 
  ! error in pak subprocess
  Caused by error in `loadNamespace(x)`:
  ! there is no package called ‘digest’
  ---
  Backtrace:
  1. pak::lockfile_create(c(deps, extra_deps), lockfile = ".github/pkg.lock", …
  2. pak:::remote(function(...) { …
  3. err$throw(res$error)

To reproduce locally:

rig system add-pak --pak-version devel

In tidyverse/dplyr#6526:

remove.packages("digest")
pak::pak(c("deps::.", "url::https://duckdb.r-universe.dev/src/contrib/duckdb_0.6.0.tar.gz"), dependencies = TRUE)

I'll work around on GHA by preinstalling digest.
krlmlr added a commit to tidyverse/dplyr that referenced this issue Nov 24, 2022
@krlmlr
Install digest manually, r-lib/pak#433
283e899
krlmlr added a commit to tidyverse/dplyr that referenced this issue Nov 24, 2022
@krlmlr
Install digest manually, r-lib/pak#433
8790798
@krlmlr
Copy link
Member Author

krlmlr commented Nov 24, 2022

🤩

@gaborcsardi
Copy link
Member

This is now deployed in devel pak.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Feb 19, 2023
(devel/R-pak) Updated 0.3.1 to 0.4.0
6826b20 
# pak 0.4.0

* pak has much improved and more informative error messages now.
  This work is not yet finished, so if you find an unclear error message,
  please open an issue. Thank you!

* The solver is now more robust for non-canonical input (e.g. `DESCRIPTION`
  files) (r-lib/pak#423).

* Better installation output. Standard output and error are now
  collected together (r-lib/pkgdepends@0669f0f8c).

* The solver is now doing a better job when multiple versions of the
  same package are present in the same repository
  (r-lib/actions#559).

* `pkg_name_check()` now works again, it needed a fix after changes at
  https://crandb.r-pkg.org.

* Explicit package names in local and URL package sources, as in
  `package=local::...` or `package=url::...` are now parsed correctly in
  dependencies.

* pak is now more robust to `Archs` fields missing from the CRAN
  metadata for packages with compiled code
  (r-lib/pak#448).

* `url::` packages now always work correctly, even if the digest package is
  not installed (r-lib/pak#433).

* pak is now more robust when installing packages from subdirectories
  of GitHub repositories (r-lib/pak#431,
  @paleolimbot).

* Parameters `?reinstall`, `?source` and `?ignore` now work correctly when
  specified in the `package=?parameter` format (#294).

* The `?ignore` parameter works correctly now.

* Dependency resolution now does not fail if a package is not found.

* pak can now install `url::` remotes from GitHub.

* pak now does not fail when the package of a `.tar.gz` GitHub
  snapshot is in a subdirectory, or in a subdirectory of a subdirectory.

* pak now errors early if it cannot deduce the name of the package
  from a `Remotes` or `Config/Needs/*` entry.

* Solver failures now include details in some cases where previously they
  did not.

* pak can now update packages in Docker containers where the
  old version was installed in the different Docker later
  (r-lib/pak#251)

* Update R version -> Bioconductor version mapping. R 4.2.x now maps to
  Bioconductor 3.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaborcsardi @krlmlr