Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lifecycle #190

Merged
merged 2 commits into from
Jul 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Imports:
crayon (>= 1.3.4),
ellipsis,
fansi,
lifecycle,
rlang (>= 0.3.0),
utf8 (>= 1.1.0),
vctrs (>= 0.2.0)
Expand Down
251 changes: 0 additions & 251 deletions R/compat-lifecycle.R

This file was deleted.

2 changes: 1 addition & 1 deletion R/deprecated.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ NULL
#' @export
#' @rdname deprecated
is_vector_s3 <- function(x) {
signal_soft_deprecated("`is_vector_s3()` is soft-deprecated in favor of `vctrs::vec_is()`.")
deprecate_soft("1.4.4", "is_vector_s3()", "vctrs::vec_is()")

UseMethod("is_vector_s3")
}
Expand Down
2 changes: 1 addition & 1 deletion R/shaft-.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#' @export
new_pillar_shaft <- function(x, ..., width = NULL, min_width = width, class = NULL, subclass = NULL) {
if (!is.null(subclass)) {
signal_soft_deprecated("The `subclass` argument to `new_pillar_shaft()` is deprecated, please use the `class` argument.")
deprecate_soft("1.4.0", "new_pillar_shaft(subclass = )", "new_pillar_shaft(class = )")
class <- subclass
}

Expand Down
1 change: 1 addition & 0 deletions R/zzz.R
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#' @import rlang
#' @import ellipsis
#' @import lifecycle
NULL

.onAttach <- function(...) {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.