Use "C" locale for system ping command on Linux #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `pingr::ping()` when system has non-english locale by default
|
Thanks! Can you please add an entry to |
|
Done! |
|
Great, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GNU/Linux systems the output of the system
pingcommand is often localized, butpingr::pingassumes that the command output contains the English word "time", which causespingr::pingto fail when using a non-English locale.This patch passes
LC_ALL=Cenvironment variable topingon Linux systems, which sets the default C locale and ensures that the output is in English.The problem might also occur on other Unix-like systems, but I cannot test that.