Update 'domain' documentation #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update this as well? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an extra line of documentation for the 'domain' argument in
trans_new().Briefly, since ggplot2 3.4.0, breaks are computed on the expanded limits capped by the domain, which requires it to be transformable. This requirement has not been communicated very clearly, as encountered in tidyverse/ggplot2#5105, that this PR aims to amend.
If so desired (but not yet included in this PR), the transformability of the domain could also be tested in
trans_new(), which could then emit a warning if the domain is untransformable.