Clickable advice for setting max number of failures

Fixes #1628

DESCRIPTION

@@ -23,7 +23,7 @@ Depends:
 Imports:
     brio,
     callr (>= 3.5.1),
-    cli (>= 3.3.0),
+    cli (>= 3.4.0),
     desc,
     digest,
     ellipsis (>= 0.2.0),

NAMESPACE

@@ -155,6 +155,7 @@ export(not)
 export(prints_text)
 export(quasi_label)
 export(run_cpp_tests)
+export(set_max_fails)
 export(set_reporter)
 export(setup)
 export(show_failure)

NEWS.md

@@ -1,5 +1,9 @@
 # testthat (development version)
 
+* New `set_max_fails()` helper to make it easier to set the maximum number of
+  failures before stopping the test suite. And the advice to set to Inf is
+  now clickable (#1628).
+
 * Fixed a warning in R >=4.2.0 on Windows that occurred when using the C++
   testing infrastructure that testthat provides (#1672).
 

R/reporter-progress.R

@@ -206,9 +206,9 @@ ProgressReporter <- R6::R6Class("ProgressReporter",
           snapshotter$end_file()
         }
 
-        stop_reporter(paste0(
-          "Maximum number of failures exceeded; quitting at end of file.\n",
-          "Increase this number with (e.g.) `Sys.setenv('TESTTHAT_MAX_FAILS' = Inf)`"
+        stop_reporter(c(
+          "Maximum number of failures exceeded; quitting at end of file.",
+          i = "Increase this number with (e.g.) {.run testthat::set_max_fails(Inf)}"
         ))
       }
     },
@@ -540,3 +540,16 @@ skip_bullets <- function(skips) {
   tbl <- table(skips)
   paste0(cli::symbol$bullet, " ", names(tbl), " (", tbl, ")")
 }
+
+
+#' Set maximum number of test failures before aborting the run
+#'
+#' This sets the `TESTTHAT_MAX_FAILS` env var which will affect both the
+#' current R process and any processes launched from it.
+#'
+#' @param n Maximum number of failures allowed.
+#' @export
+#' @keywords internal
+set_max_fails <- function(n) {
+  Sys.setenv('TESTTHAT_MAX_FAILS' = n)
+}

R/reporter-zzz.R

@@ -59,7 +59,7 @@ with_reporter <- function(reporter, code, start_end_reporter = TRUE) {
 
 stop_reporter <- function(message) {
   signal(message, "testthat_abort_reporter")
-  abort(message)
+  cli::cli_abort(message, error_call = NULL)
 }
 
 #' Find reporter object given name or object.