Avoid defining the visibility attribute on Windows #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborcsardi
approved these changes
Aug 23, 2022
DavisVaughan
added a commit
to r-lib/cpp11
that referenced
this pull request
Aug 25, 2022
… them (#279) * Bump Ubuntu version from 18.04 to 20.04 * Fully update GitHub Actions workflows * Avoid `R_compact_intrange()` in favor of `:` Closes #280 * Avoid unused variable warning on Windows about `cpp11::preserved` * Add a remote on r-lib/testthat#1673 * Add old archives to be able to install gcc 4.8 * Depend only on dev testthat now that the PR has been merged * Set `CC` as well for `pkgbuild:::has_compiler_colored_diagnostics()` Otherwise this will incorrectly return `TRUE` because it compiles a C program rather than a C++ one to check if color support is available, which adds the `-fdiagnostics-color=always` flag, but g++ 4.8 doesn't actually support that, so the compilation of the C++ code in the vignettes would fail * NEWS bullet * Pin to a specific testthat SHA * Use `seq()` rather than `:` to generate the ALTREP compact-seq vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1672 , see that issue for my full description of the problem.
Confirmed that the warning in the
windows-latest (release)GitHub Actions workflow of this cpp11 PR disappeared when I added a remote on this testthat PR r-lib/cpp11@d15902a