Implement expect_without_warnings() and friends #1690
Conversation
NAMESPACE
Outdated
| @@ -124,6 +124,10 @@ export(expect_type) | |||
| export(expect_vector) | |||
| export(expect_visible) | |||
| export(expect_warning) | |||
| export(expect_without_condition) | |||
There was a problem hiding this comment.
I think these names are a bit too long. They will dominate the line width, making it harder to read the actual logic.
There was a problem hiding this comment.
Do you have any ideas for alternatives? I don't particularly like expect_no_warnings() because expect_no_warnings(foo(), class = "abc") doesn't make as much sense to me.
There was a problem hiding this comment.
Might be too literary but:
expect_sans_warnings(foo(), class = "foo")?
There was a problem hiding this comment.
expect_no_warnings(foo(), class = "abc")doesn't make as much sense to me.
I don't love the "no" particle but I like the concision.
Does it make sense to read it as "expect no warnings of class 'abc'"?
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com> Co-authored-by: Lionel Henry <lionel.hry@gmail.com>
|
I marked these as experimental, which makes me feel better about including them in a patch release. |
Fixes #1679
I've kept the interface deliberately very minimum; let me know if you think there's anything I'm missing.