Skip to content

Commit

Permalink
True warning instead of msg
Browse files Browse the repository at this point in the history
  • Loading branch information
Jean-Romain committed Feb 2, 2021
1 parent 7f94ee2 commit 36972ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Fix: build failure with GCC 4.x
- Fix: gcc-asan signed integer overflow.
- Fix: when reading an non supported extra bytes attribute rlas used to print a warning message. It now throws a real warning.
- Change: use `tinytest` instead of `testthat`
- New: `read.lasheader()` now reads the extended variable length record (EVLR)
- New: `write.las()` now writes all GeoKeyDirectoryTag + GeoAsciiParamsTag + GeoDoubleParamsTag
Expand Down
5 changes: 4 additions & 1 deletion src/rlasstreamer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,10 @@ void RLASstreamer::allocation()
extra_bytes_attr.push_back(extrabyte);
}
else
Rprintf("WARNING: data type %d of attribute %d not implemented.\n", extrabyte.data_type, extrabyte.id);
{
std::string msg = std::string("data type ") + std::to_string(extrabyte.data_type) + std::string(" of extra bytes attribute ") + std::to_string(extrabyte.id) + std::string(" is deprecated and not supported by rlas.");
Rf_warningcall(R_NilValue, msg.c_str());
}
}
}
}
Expand Down

0 comments on commit 36972ad

Please sign in to comment.