Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Text Area Description to header reader/writer #63

Closed
wants to merge 3 commits into from

Conversation

floriandeboissieu
Copy link
Contributor

Hi Jean-Romain,
In the current PR, I propose an implementation of the VLR Text Area Description for header reader/writer.
Cheers

@Jean-Romain
Copy link
Collaborator

Jean-Romain commented Jul 31, 2023

Thank you, I indeed missed this part of the specs. Can you make a clean PR. It seems that the diff is reporting much more code modifications than you actually did and it is thus hard to see what you actually changed. Thank you.

@floriandeboissieu
Copy link
Contributor Author

floriandeboissieu commented Aug 1, 2023

The large change is due to an excessive indentation I corrected (l270-l409 in the original readheader.cpp file). Unfortunately, github diff does not report it well... but according to https://github.blog/2011-10-21-github-secrets/
adding ?w=1 to the commit url would show that it is only space changes.

In order to make all that clean, i.e. separate the real changes from the indentation changes, I made another PR #64 as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants