-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qgis_query_version(): don't require the commit hash for regular releases #118
Conversation
Two problems in the GHA R-CMD-check workflows, probably related to the newer QGIS version 3.28.2:
Both problems are not related to this PR however. (*) Update: there was a regression in the Ubuntu-nightly job, i.e. it had become identical to the Ubuntu workflow; this will be fixed in a separate PR. |
@Nowosad can you check again that all goes well with this change, in Fedora? Same code; the |
It seems to work well: # remotes::install_github("paleolimbot/qgisprocess@fedora")
library(qgisprocess)
#> Using 'qgis_process' in the system PATH.
#> QGIS version: 3.28.2-Firenze
#> Configuration loaded from '~/.cache/R-qgisprocess/cache-0.0.0.9000.rds'
#> Run `qgis_configure(use_cached_data = TRUE)` to reload cache and get more details.
#> >>> If you need another installed QGIS version, run `qgis_configure()`;
#> see its documentation if you need to preset the path of qgis_process.
#> - Using JSON for input serialization.
#> - Using JSON for output serialization.
qgis_configure()
#> getOption('qgisprocess.path') was not found.
#> Sys.getenv('R_QGISPROCESS_PATH') was not found.
#> Trying 'qgis_process' on PATH...
#> Success!
#> QGIS version: 3.28.2-Firenze
#> Saving configuration to '~/.cache/R-qgisprocess/cache-0.0.0.9000.rds'
#> Metadata of 653 algorithms queried and stored in cache.
#> Run `qgis_algorithms()` to see them.
#> - Using JSON for input serialization.
#> - Using JSON for output serialization. Created on 2023-01-05 with reprex v2.0.2 |
Fixes #117; follow-up for #115.
Now the presence of a commit hash is only verified in QGIS dev versions.
For QGIS dev versions with no commit hash advertised (i.e. if not built from a git repo context), a warning is issued and the version string will become e.g.:
3.29.0-Master, development state unclear: exported
Meanwhile, I noticed a segfault for the
native:printlayouttopdf
test in Linux Mint 21.1 (Ubuntu 22.04), when checking the package locally, possibly triggered by upgrading QGIS to 3.28.2. The segfault seems to occur after successfully doing the job though.qgis_process
also throws a weird message 'Problem with SAGA installation: unsupported SAGA version (found: 8.2.2, required: 2.3.).'. Perhaps this is something going on just here, let's see what the GHA workflows say. Update wrt SAGA: 'unsupported' may make sense, since SAGA was recently updated to 8.2.2 (ubuntugis-unstable PPA) which is probably too high for QGIS 3.28.2; QGIS dev version doesn't complain anymore about that.