Avoid side effects on PROJ_LIB when loading sf #1226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto set and reset of PROJ_LIB and GDAL_DATA upon call of st_crs and st_transform, and reset on.exit, instead than changing on .load and .unload - first push to see if checks / tests are ok.
Auto set and reset of PROJ_LIB and GDAL_DATA upon call of st_crs and st_transform, and reset on.exit, instead than changing on .load and .unload - first push to see if checks / tests are ok.
|
...still failing on Appveyor - will dig further in a few days.... |
|
Closing this - much more difficult than expected, so it is much better to wait for GDAL3/PROJ6 support on Windows binary on R 4.0... Sorry for the clutter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to solve r-spatial/discuss#31 for
sf, by avoiding changing environment variables on load. Required changes are done on-the-fly upon calls tost_crsorst_transform, and automatically reverted on.exit. (See comments on last commit)Hope this helps and makes sense.
PS2:
testthattest are all passing, but many differences are found on tests comparing with Rout.save files. However, the differences seem similar to those also observed on travis build onwkt2branch.