don't negate Y-res in default geotransform #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to revert this back, because otherwise r = read_stars("~/svn/rgdal/pkg/inst/pictures/Rlogo.jpg")gives
|
|
Well, it should be changed in stars which is what I said above ... |
edzer
added a commit
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should return as per the GDAL documentation - with Y-res = 1.
Cf #1306
This way, the
gdal_read()function does as GDAL says, and other tools can apply the Y-flip and shift to put a non-geo raster into natural orientation, and with [0, nrow, 0, ncol].I had more to follow up with stars but that's stalled for now