Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of tic #841

Merged
merged 4 commits into from
Sep 23, 2018
Merged

Use latest version of tic #841

merged 4 commits into from
Sep 23, 2018

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Sep 9, 2018

@krlmlr did a lot of work lately and fixed most of the issues. I cannot fully guarantee that this version is fully stable now but we are close to a CRAN release.

@edzer You can use this branch to solve the test errors. The tic implementation looks fine.

I also tidied the DESCRIPTION using usethis::use_tidy_description()

@edzer
Copy link
Member

edzer commented Sep 14, 2018

Still some issues, looks like tic related to me: https://travis-ci.org/r-spatial/sf/jobs/428628046

@pat-s
Copy link
Member Author

pat-s commented Sep 14, 2018

Yes, saw it.

Works locally, hm. Do you know what the nativeRoutines refers to? https://travis-ci.org/r-spatial/sf/jobs/428628046#L5445

Some c++ stuff that is missing here? The error is thrown from pkgdown::build_site(). Atm I don't think its an tic issue but rather travis related.

@krlmlr
Copy link
Contributor

krlmlr commented Sep 14, 2018

Maybe it would help to avoid stashing in pre-deploy: see link at https://travis-ci.org/r-spatial/sf/jobs/428628046#L5232 .

This might be a good default for .travis.yml, too.

@edzer
Copy link
Member

edzer commented Sep 23, 2018

Any news here, @pat-s ? Would like to get this working.

Merge branch 'master' into tic

# Conflicts:
#	DESCRIPTION
@edzer edzer merged commit 6d0c916 into r-spatial:master Sep 23, 2018
@pat-s
Copy link
Member Author

pat-s commented Sep 23, 2018

Still trying, unsure why the sf installation in the deploy step fails.

It could be caused because its installed in a new R process and this process is missing some c++ deps, i.e. the "native routines" error. Currently trying to force installation in the same R process.

PS: The stage of the PR you just merged included a duplicate "version" field in the DESCRIPTION by accident.

edzer added a commit that referenced this pull request Sep 23, 2018
@edzer
Copy link
Member

edzer commented Sep 23, 2018

@etiennebr I now see errors coming from tests you wrote: https://travis-ci.org/r-spatial/sf/builds/432212868 could you pls take a look?

@pat-s
Copy link
Member Author

pat-s commented Sep 23, 2018

new_process = F didn't help.
Atm I have no clue where the error comes from and why it appears.
I don't think its related to tic (maybe pkgdown or travis itself).
Deployment and pkgdown currently works for all repos besides sf.

Do you know where this "nativeRoutines" error might come from? It seems to look for a dll file in src that can't be found.

@etiennebr
Copy link
Member

Sure! For my own reference: https://travis-ci.org/r-spatial/sf/jobs/432212869#L4459

etiennebr added a commit to etiennebr/sf that referenced this pull request Sep 25, 2018
@etiennebr etiennebr mentioned this pull request Sep 25, 2018
@pat-s
Copy link
Member Author

pat-s commented Sep 25, 2018

@edzer Trying to run the pkgdown stuff manually later (without the custom tic step). Not expecting that anything changes but lets see.

If that doesn't help we can try to run this step on appveyor (to see if its a travis thing).

@edzer
Copy link
Member

edzer commented Sep 29, 2018

The nativeRoutines stuff had apparently to do with r-devel;l now deploying under release, which works. Thanks!

@pat-s
Copy link
Member Author

pat-s commented Oct 1, 2018

ahh, all that checking and in the end its sth that trivial - well, glad that it works now (hopefully for a longer time ;)!

@edzer
Copy link
Member

edzer commented Oct 17, 2018

I now see in various repos a break at random points with:

Error: HTTP error 403.
  API rate limit exceeded for 104.154.120.187. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

does this have anything to do with tic?

@krlmlr
Copy link
Contributor

krlmlr commented Oct 17, 2018

Thanks, I'm seeing it too in tibble, but thought this is some random error.

@gaborcsardi: Do you see a reason why GITHUB_PAT would be ignored now when using remotes::install_github() ? I've seen that the message that the env var is used is no longer printed, but it should still work?

@gaborcsardi
Copy link

It should. There was a mishap with it in the dev version, but AFAIK this was fixed for the CRAN version. @jimhester ?

@edzer
Copy link
Member

edzer commented Nov 10, 2018

I'm seeing identical tic-related errors again here and here. It it something with my setup, or with tic?

@pat-s
Copy link
Member Author

pat-s commented Nov 10, 2018

I assume it is related to r-lib/roxygen2#822.

We have a workaround for this already, let me do a quick test.

@pat-s
Copy link
Member Author

pat-s commented Nov 10, 2018

I was right. Opened PRs in the respective repos.

@edzer
Copy link
Member

edzer commented May 26, 2019

Hi @pat-s , any idea what is going wrong here? https://travis-ci.org/r-spatial/sf/jobs/537456557

@pat-s
Copy link
Member Author

pat-s commented May 26, 2019

The error message looks a bit strange but I hope that #1058 solves it.
The old (manual) approach should actually still work but the error message from the build above is new to me.

@edzer
Copy link
Member

edzer commented May 26, 2019

Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants