-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest version of tic #841
Conversation
Still some issues, looks like tic related to me: https://travis-ci.org/r-spatial/sf/jobs/428628046 |
Yes, saw it. Works locally, hm. Do you know what the Some c++ stuff that is missing here? The error is thrown from |
Maybe it would help to avoid stashing in pre-deploy: see link at https://travis-ci.org/r-spatial/sf/jobs/428628046#L5232 . This might be a good default for |
Any news here, @pat-s ? Would like to get this working. |
Merge branch 'master' into tic # Conflicts: # DESCRIPTION
Still trying, unsure why the It could be caused because its installed in a new R process and this process is missing some c++ deps, i.e. the "native routines" error. Currently trying to force installation in the same R process. PS: The stage of the PR you just merged included a duplicate "version" field in the DESCRIPTION by accident. |
@etiennebr I now see errors coming from tests you wrote: https://travis-ci.org/r-spatial/sf/builds/432212868 could you pls take a look? |
Do you know where this "nativeRoutines" error might come from? It seems to look for a dll file in |
Sure! For my own reference: https://travis-ci.org/r-spatial/sf/jobs/432212869#L4459 |
Related r-spatial#841, #264
@edzer Trying to run the If that doesn't help we can try to run this step on appveyor (to see if its a travis thing). |
The |
ahh, all that checking and in the end its sth that trivial - well, glad that it works now (hopefully for a longer time ;)! |
I now see in various repos a break at random points with:
does this have anything to do with tic? |
Thanks, I'm seeing it too in tibble, but thought this is some random error. @gaborcsardi: Do you see a reason why |
It should. There was a mishap with it in the dev version, but AFAIK this was fixed for the CRAN version. @jimhester ? |
I assume it is related to r-lib/roxygen2#822. We have a workaround for this already, let me do a quick test. |
I was right. Opened PRs in the respective repos. |
Hi @pat-s , any idea what is going wrong here? https://travis-ci.org/r-spatial/sf/jobs/537456557 |
The error message looks a bit strange but I hope that #1058 solves it. |
Thanks a lot!! |
@krlmlr did a lot of work lately and fixed most of the issues. I cannot fully guarantee that this version is fully stable now but we are close to a CRAN release.
@edzer You can use this branch to solve the test errors. The
tic
implementation looks fine.I also tidied the DESCRIPTION using
usethis::use_tidy_description()