Improve continuous integration + tweak to improve R CMD CHECK log #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test pkgdown config * test
* Update example of tm_layout to silence R CMD CHECK note. * Update tm_symbols example to silence R CMD CHECK NOTE * Fix R CMD CHECK on class * Add :: for non-base functions. * Remove :: or ::: usage for internal tmap functions.
…ryCatch to fix a bug introduced by a713947
…omeone tries to install the development version. To be deleted.
> # Example to illustrate the type of titles
> tm_shape(World) +
+ tm_polygons(c("income_grp", "economy"), title = c("Legend Title 1", "Legend Title 2")) +
+ tm_layout(main.title = "Main Title",
+ main.title.position = "center",
+ main.title.color = "blue",
+ title = c("Title 1", "Title 2"),
+ title.color = "red",
+ panel.labels = c("Panel Label 1", "Panel Label 2"),
+ panel.label.color = "purple",
+ legend.text.color = "brown")
Deprecated tmap v3 code detected. Code translated to v4
Warning: The 'title' argument of tm_layout is deprecated as of tmap 4.0. Please use tm_title instead.
Warning: The 'main.title' argument of tm_layout is deprecated as of tmap 4.0. Please use tm_title instead.
Error in if (is.ena(l$title)) l$title = paste0(names(v), attr(cls, "units")) :
the condition has length > 1
Calls: <Anonymous> ... with -> with.default -> eval -> eval -> apply_scale
Propose an alternative to make it an error.
Nowosad
requested changes
Sep 15, 2023
There was a problem hiding this comment.
@olivroy Great work! Please answer to my three comments...
@mtennekes Please take a look (and merge if you think everything is fine)
|
@Nowosad Thanks you for your comments! Addressed them ! |
|
I also copied the content of NEWS from CRAN and changed it to NEWS.md to make it appear on the package website.
|
olivroy
changed the title
Nowosad
approved these changes
Sep 15, 2023
|
Looking good! |
|
Note: about the failed workflows notifications, that can be personalized in Github probably, for a repo and an organization. I think the notifications are not useful as there are too many things failing for now (possibly by design). But the logs are useful, to see where and when failures happen in the future. https://github.com/settings/notifications |
|
Great team work, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #774
Hi @Nowosad ,
here is a messy PR that rassembles my observations / modifications.
Adds CI GH actions (they fail, but I think it's fine. They can always be disabled if needed. But they really helped me fix some easy problems before the rest of the heavy lifting gets done
Note that the remotes field must be removed prior to CRAN submission. But leave it as long as these packages are not on CRAN (tmaptools and cols4all)
Edit: Some examples and tests are failing, this PR doesn't aim to fix that, but rather help pinpointing this