Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build ignore vignettes + prefix sf calls #946

Merged
merged 2 commits into from
Oct 23, 2024
Merged

build ignore vignettes + prefix sf calls #946

merged 2 commits into from
Oct 23, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 23, 2024

No description provided.

@olivroy olivroy changed the title Add back VignetteBuilder temporarily for CRAN check build ignore vignettes + prefix sf calls Oct 23, 2024
@mtennekes mtennekes merged commit 65c603d into master Oct 23, 2024
9 checks passed
@olivroy olivroy deleted the sa branch October 23, 2024 19:40
@mtennekes
Copy link
Member

Thanks! Is it possible (easy) to show the dev site on https://r-tmap.github.io/tmap/ ? And optionally the old site at for instance https://r-tmap.github.io/tmap/release?

@olivroy
Copy link
Contributor Author

olivroy commented Oct 23, 2024

I am not aware of a simple way to do this. Deleting mode: auto from _pkgdown.yml will show the dev site only... I think this is fine now!

I have been using tmap's release candidate for ~ 1 month now, and I got everything working perfectly! Since we are quite close to release, I don't see a need for keeping v3 site around.

(It will disappear anyway when v4 is released)

There is an enhancement request on pkgdown's side: r-lib/pkgdown#1373

mtennekes added a commit that referenced this pull request Oct 23, 2024
@mtennekes
Copy link
Member

mtennekes commented Oct 23, 2024

Totally agree!

Now is the time to finish those vignettes, and finish the documentation (especially about tm_options, which those many options).

@olivroy
Copy link
Contributor Author

olivroy commented Oct 23, 2024

Agreed!

there are also a couple of issues left. You may want to scan through again.

In a53cab5, I added the revdep check workflow from https://github.com/r-devel/recheck. Hopefully, we'll get insights about reverse dependencies. I will open an issue with the problems once the run finishes.

https://github.com/r-tmap/tmap/actions/runs/11488046296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants