Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: liquid template with custom naming #30

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Jun 26, 2024

This PR adapts base-parachain so it becomes a liquid template that can be used by tooling like pop-cli to bootstrap user projects.

  • User given name will be applied to the node, runtime, resulting binary and a few configurations in the respective Cargo files and network.toml.

Downsides:

  • This change makes base-parachain move away from being a rust project, cargo will error out as the syntax used for the template won't make it "cargo compliant".
    ( For instance, cargo fmt won't be able to run, and so this PR won't comply with the current CI, modifying the CI itself could be part of this PR if we all agree this is a good way forward )
  • Maintenance of this template, like upgrading it to new polkadot-sdk versions, might be a tad more painful because of the above.

Note:

  • With the sight set on omni-node advancements, we might/should get rid of everything node from this template. Making the maintenance not that big of a problem. And so, making it wort it to advance in this direction and evolve the template.
  • I had to move the macro construct_async_run outside of the node/src/command.rs file so that the template could be parsed properly. Now it lives in node/src/utils.rs.

@Daanvdplas
Copy link
Collaborator

What is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants