Actually raise exception #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this! |
|
Yes thanks, this does look like an oversight and test coverage miss. I wonder if the branch is actually reachable (without calling |
|
Hi, sorry to revive this thread, but Bradley (@shenanigansd ) let me know this got merged. I hesitated to open the PR myself after a previous one was rejected due to my carelessness, so Brad kindly contributed it on my behalf. Originally, I was checking in the Python Discord about whether the exception should be raised, and Bradley helpfully sanity checked me on this, found the issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from https://www.pythondiscord.com/ 👋🏻
We had someone come into our Discord server today asking if this was correct.
Looks like it's missing a
raise, so here's a quick PR.