forked from slok/sloth
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: added slo duplicates check during validate
Issue slok#493
- Loading branch information
Showing
8 changed files
with
367 additions
and
12 deletions.
There are no files selected for viewing
87 changes: 87 additions & 0 deletions
87
test/integration/prometheus/testdata/validate_with_duplicates/bad-prom-multi-duplicates.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| --- | ||
| version: "prometheus/v1" | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| error_query: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| total_query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| error_ratio_query: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| page_alert: | ||
| disable: true | ||
| ticket_alert: | ||
| disable: true | ||
|
|
||
| --- | ||
| version: "prometheus/v1" | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" # duplicate | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| error_query: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| total_query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" # duplicate | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| error_ratio_query: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| page_alert: | ||
| disable: true | ||
| ticket_alert: | ||
| disable: true |
47 changes: 47 additions & 0 deletions
47
test/integration/prometheus/testdata/validate_with_duplicates/k8s/bad-k8s-1-duplicate.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apiVersion: sloth.slok.dev/v1 | ||
| kind: PrometheusServiceLevel | ||
| metadata: | ||
| name: svc | ||
| namespace: test-ns | ||
| spec: | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| errorQuery: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| totalQuery: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| errorRatioQuery: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| pageAlert: | ||
| disable: true | ||
| ticketAlert: | ||
| disable: true |
47 changes: 47 additions & 0 deletions
47
test/integration/prometheus/testdata/validate_with_duplicates/k8s/bad-k8s-1-original.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apiVersion: sloth.slok.dev/v1 | ||
| kind: PrometheusServiceLevel | ||
| metadata: | ||
| name: svc | ||
| namespace: test-ns | ||
| spec: | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| errorQuery: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| totalQuery: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| errorRatioQuery: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| pageAlert: | ||
| disable: true | ||
| ticketAlert: | ||
| disable: true |
23 changes: 23 additions & 0 deletions
23
...gration/prometheus/testdata/validate_with_duplicates/openslo/bad-openslo-1-duplicate.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| apiVersion: openslo/v1alpha | ||
| kind: SLO | ||
| metadata: | ||
| name: slo1 | ||
| displayName: Integration test SLO1 | ||
| spec: | ||
| service: svc01 | ||
| description: "this is SLO1." | ||
| budgetingMethod: Occurrences | ||
| objectives: | ||
| - ratioMetrics: | ||
| good: | ||
| source: prometheus | ||
| queryType: promql | ||
| query: sum(rate(http_request_duration_seconds_count{job="myservice",code!~"(5..|429)"}[{{.window}}])) | ||
| total: | ||
| source: prometheus | ||
| queryType: promql | ||
| query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| target: 0.999 | ||
| timeWindows: | ||
| - count: 30 | ||
| unit: Day |
23 changes: 23 additions & 0 deletions
23
...egration/prometheus/testdata/validate_with_duplicates/openslo/bad-openslo-1-original.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| apiVersion: openslo/v1alpha | ||
| kind: SLO | ||
| metadata: | ||
| name: slo1 | ||
| displayName: Integration test SLO1 | ||
| spec: | ||
| service: svc01 | ||
| description: "this is SLO1." | ||
| budgetingMethod: Occurrences | ||
| objectives: | ||
| - ratioMetrics: | ||
| good: | ||
| source: prometheus | ||
| queryType: promql | ||
| query: sum(rate(http_request_duration_seconds_count{job="myservice",code!~"(5..|429)"}[{{.window}}])) | ||
| total: | ||
| source: prometheus | ||
| queryType: promql | ||
| query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| target: 0.999 | ||
| timeWindows: | ||
| - count: 30 | ||
| unit: Day |
42 changes: 42 additions & 0 deletions
42
test/integration/prometheus/testdata/validate_with_duplicates/prom/bad-prom-1-duplicate.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| version: "prometheus/v1" | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| error_query: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| total_query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| error_ratio_query: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| page_alert: | ||
| disable: true | ||
| ticket_alert: | ||
| disable: true |
42 changes: 42 additions & 0 deletions
42
test/integration/prometheus/testdata/validate_with_duplicates/prom/bad-prom-1-original.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| version: "prometheus/v1" | ||
| service: "svc01" | ||
| labels: | ||
| global01k1: global01v1 | ||
| slos: | ||
| - name: "slo1" | ||
| objective: 99.9 | ||
| description: "This is SLO 01." | ||
| labels: | ||
| global02k1: global02v1 | ||
| sli: | ||
| events: | ||
| error_query: sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| total_query: sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| name: myServiceAlert | ||
| labels: | ||
| alert01k1: "alert01v1" | ||
| annotations: | ||
| alert02k1: "alert02k2" | ||
| pageAlert: | ||
| labels: | ||
| alert03k1: "alert03v1" | ||
| ticketAlert: | ||
| labels: | ||
| alert04k1: "alert04v1" | ||
| - name: "slo02" | ||
| objective: 95 | ||
| description: "This is SLO 02." | ||
| labels: | ||
| global03k1: global03v1 | ||
| sli: | ||
| raw: | ||
| error_ratio_query: | | ||
| sum(rate(http_request_duration_seconds_count{job="myservice",code=~"(5..|429)"}[{{.window}}])) | ||
| / | ||
| sum(rate(http_request_duration_seconds_count{job="myservice"}[{{.window}}])) | ||
| alerting: | ||
| page_alert: | ||
| disable: true | ||
| ticket_alert: | ||
| disable: true |
Oops, something went wrong.