Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORLD vocoder support #166

Closed
hash2430 opened this issue Jul 16, 2019 · 3 comments
Closed

WORLD vocoder support #166

hash2430 opened this issue Jul 16, 2019 · 3 comments

Comments

@hash2430
Copy link

I have created a branch that supports WORLD vocoder.
https://github.com/hash2430/dv3_world
I might not make a pull request for a while since I have not started that branch from fork and I must go through some procedure to make a pull request. I don't want to go through that trouble not knowing if that pull request is going to be accepted by r9y9.
But in the meantime, anyone who's looking for WORLD vocoder support are welcome to browse my repository.

@r9y9
Copy link
Owner

r9y9 commented Jul 24, 2019

Sorry for the late reply. Great work! Probably the easiest option is to maintain your repo separately, but I am willing to accept a PR and review changes (not sure how hard it is though). If it turns out it's difficult to merge, then how about adding a link to your repo in the README of my repo?

@r9y9 r9y9 added the feature label Jul 24, 2019
@hash2430
Copy link
Author

I suppose adding link to my repo in your README would be the easiest way for both of us and those who are looking for WORLD support for DV3.
I have a couple of ways in mind to optimize the WORLD part of the converter and I don't want to bother you with PR everytime I optimize minor details.
Thanks!

@stale
Copy link

stale bot commented Sep 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2019
@stale stale bot closed this as completed Oct 5, 2019
r9y9 added a commit that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants