Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional ContentEquatable conformance to Array #101

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Add conditional ContentEquatable conformance to Array #101

merged 2 commits into from
Jun 9, 2020

Conversation

nkristek
Copy link
Contributor

@nkristek nkristek commented May 5, 2020

Checklist

Description

This adds a conditional ContentEquatable conformance to Array<T> if T conforms to ContentEquatable.

Related Issue

#100: Array<T: ContentEquatable> does not conform to ContentEquatable

Motivation and Context

This potentially simplifies the implementation of ContentEquatable and thus Differentiable of a container type, if it contains an array of differentiable items.

Closes #100

Impact on Existing Code

Existing code should not be affected, but this can make it easier to implement ContentEquatable and thus Differentiable conformance.

Screenshots (if appropriate)

@ra1028
Copy link
Owner

ra1028 commented Jun 9, 2020

@nkristek
Sorry for my late response!
LGTM

@ra1028 ra1028 merged commit f8c8d1e into ra1028:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array<T: ContentEquatable> does not conform to ContentEquatable
3 participants