Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme and rendering issue on windows #818

Closed
4 tasks done
dsm opened this issue Jul 7, 2024 · 7 comments · Fixed by #820, #828 or #842
Closed
4 tasks done

Dark theme and rendering issue on windows #818

dsm opened this issue Jul 7, 2024 · 7 comments · Fixed by #820, #828 or #842
Assignees
@wawuwo
Labels
bug
Milestone
24.3.0

Comments

@dsm
Copy link
Contributor

dsm commented Jul 7, 2024 •
edited by ra3xdh
Loading

Hi, Qt added new theming for win11 named Windows11 style beginning Qt 6.7. This theme can automatically switch dark and light mode. In dark mode editing component color of the value is white. And some rendering artifact. I add some pictures. @wawuwo

Problem 1:

image

Problem 2:

image

Problem 3:

image

edit from @ra3xdh : Added TODO list

  • When property value is being edited, value text is misplaced
  • When property value is being edited and QT theme is switched to dark mode, value text has white color and is barely visible
  • When property value is being edited, value text is visible only partially
  • Connections to component ports are rendered incorrectly; if port has only one connection is has to be rendered as a little filled square
@dsm dsm changed the title Dark theme issue on win11 Dark theme and rendering issue on win11 Jul 7, 2024
@dsm dsm changed the title Dark theme and rendering issue on win11 Dark theme and rendering issue on windows Jul 7, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Jul 7, 2024

I have also recently noticed that the dots on device pins are disappeared after schematic rendering refactoring.

  • Old
    image
  • New -- no dots
    image

@wawuwo
Copy link
Contributor

wawuwo commented Jul 7, 2024 •
edited
Loading

Hi guys!

Here is a checklist of problems to check that I've understood them well and to control the progress. Please correct me if I'm wrong:

  • When property value is being edited, value text is misplaced
  • When property value is being edited and QT theme is switched to dark mode, value text has white color and is barely visible
  • When property value is being edited, value text is visible only partially
  • Connections to component ports are rendered incorrectly; if port has only one connection is has to be rendered as a little filled square

@dsm
Copy link
Contributor Author

dsm commented Jul 7, 2024 •
edited
Loading

The application is already in dark theme, but when the value is changed, there is a white background and white text in windows11, but in macOS, this does not happen in the dark theme, it is white text on a black background. In problem 2, there is also a leftover of the value that normally appears on the white background, which should not be there.

wawuwo added a commit to wawuwo/qucs_s that referenced this issue Jul 7, 2024
@wawuwo
Draw component port as filled square when it has only one connection
5d11d94 
This is a fix of regression introduced in 4e9e968, the problem
is described in ra3xdh#818
@wawuwo wawuwo mentioned this issue Jul 7, 2024
Merged
@ra3xdh ra3xdh linked a pull request Jul 8, 2024 that will close this issue
Draw component port as filled square when it has only one connection #820
Merged
@ra3xdh
Copy link
Owner

ra3xdh commented Jul 8, 2024

The #820 resolves the problem with nodes rendering. I have added TODO list for this issue.

ra3xdh pushed a commit that referenced this issue Jul 8, 2024
@wawuwo @ra3xdh
Draw component port as filled square when it has only one connection
ef0a4c8 
This is a fix of regression introduced in 4e9e968, the problem
is described in #818
wawuwo added a commit to wawuwo/qucs_s that referenced this issue Jul 8, 2024
@wawuwo
Use stylesheet to change background color when editing a property
2f7a57e 
In ra3xdh#818 @dsm mentioned that when property value text
is being edited, the color of text background depends on current
colorscheme (dark/light), which sometimes makes text barely visible.

With this commit the background color of QLineEdit, used to modifying
property value, is set using stylesheet instead of QPalette.
@wawuwo wawuwo mentioned this issue Jul 8, 2024
Merged
@wawuwo
Copy link
Contributor

wawuwo commented Jul 8, 2024 •
edited
Loading

@dsm I made a patch which uses different approach to control colours when property values is being edited, but unfortunately I don't have a windows-based machine to try it out. Could you please try the patch to check if it fixes the problem №2?

UPD: hadn't seen you comment in #828 when I added this comment; I'm glad it works!

@dsm
Copy link
Contributor Author

dsm commented Jul 8, 2024 •
edited
Loading

Yes this patch fixed Problem 2.

@ra3xdh ra3xdh linked a pull request Jul 9, 2024 that will close this issue
Use stylesheet to change appearance of QLineEdit used for editing a property value #828
Merged
wawuwo added a commit to wawuwo/qucs_s that referenced this issue Jul 14, 2024
@wawuwo
Fix component's property value editbox position and size
9d72037 
See: ra3xdh#818
@wawuwo wawuwo mentioned this issue Jul 14, 2024
Merged
@ra3xdh ra3xdh linked a pull request Jul 14, 2024 that will close this issue
Fix property editbox position and size #842
Merged
@ra3xdh
Copy link
Owner

ra3xdh commented Jul 14, 2024

The full fix provided by #842 Closing as completed.

@ra3xdh ra3xdh closed this as completed Jul 14, 2024
@ra3xdh ra3xdh added the bug label Jul 14, 2024
@ra3xdh ra3xdh added this to the 24.3.0 milestone Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wawuwo wawuwo

Labels
bug
Projects
None yet
Milestone
24.3.0
3 participants
@ra3xdh @wawuwo @dsm