Fix source components rendering quirks #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type of primitive allows to draw complex figures which consist of multiple lines. In contrast to drawing just multiple independent lines, when drawing a polyline QPainter can join segments in pretty way.
|
Oops, turns out I've confused directions of a couple of arrows. Preparing a |
|
Thanks for the contribution! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This a follow-up to #723 and another portion of changes to components to make them look a bit prettier. This time components from "sources" groups were in work.
With this PR also comes a new type of drawing primitive — the so called "Polyline" which allows to draw compound lines consisting of several segments and make good-looking joining of them. I had to add be able to draw nice arrow heads without strange edges etc.
There is a lot of affected components and I was to lazy (shame on me!) to make before/after images this time, but I think a change in component's rendering is something self-describing and easy to see so lack of before/after images shouldn't be a problem.