Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New symbol action #757

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Add New symbol action #757

merged 5 commits into from
Jun 17, 2024

Conversation

ra3xdh
Copy link
Owner

@ra3xdh ra3xdh commented Jun 15, 2024

This PR contains the following improvements:

  • Added New symbol action on toolbar as discussed in Improve SpiceLibComp device #679
  • Implemented Schematic::isSymbolOnly property.
  • Locked switching schematic/symbol if document is symbol only.
  • Suggest the sym extension on Save As if document is symbol only. Not possible to save symbol as schematic. Saving schematic as symbol only works.
  • Added new symnew.svg icon

@ra3xdh ra3xdh added this to the 24.3.0 milestone Jun 15, 2024
@ra3xdh ra3xdh linked an issue Jun 15, 2024 that may be closed by this pull request
7 tasks
@ra3xdh ra3xdh mentioned this pull request Jun 15, 2024
7 tasks
@ra3xdh ra3xdh marked this pull request as draft June 15, 2024 15:30
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jun 16, 2024

I have added the following fixes:

  • The PortSymbol::numberStr must be always be a number. Otherwise it may cause symbol load issues.
  • Allow delete port in symbol only mode

@ra3xdh ra3xdh marked this pull request as ready for review June 16, 2024 16:59
@ra3xdh ra3xdh merged commit 89141a5 into current Jun 17, 2024
7 checks passed
@ra3xdh ra3xdh deleted the 679_new_symbol branch June 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SpiceLibComp device
1 participant