QucsAttenuator: Ensure Zout=Zin in QW and Lpad attenuators #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found that when selecting the QW or L-pad attenuators and marking the option to include the S-parameter analysis block, the impedance of the output term was not Z0 if Z0 != 50 This happened because these attenuator topologies were missing from slotSetText_Zin( double val ). This function calls the calculation function in order to update the power dissipation data whenever the user changes Z0.
andresmmera
changed the title
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello:
I have found that when selecting the QW or L-pad attenuators and marking the option to include the S-parameter analysis block, the impedance of the output term was not$Z_0$ if $Z_0 \neq 50 \Omega$
This happened because these attenuator topologies were missing from slotSetText_Zin(). This function calls the calculation function in order to update the power dissipation data whenever the user changes$Z_0$ .
Steps to reproduce
Select a L-pad attenuator (or a QW attenuator) and set$Z_0 =75 \Omega$
Check the S-parameter box option
Paste the schematic in Qucs-S: The impedance of the output port is not$75 \Omega$ , but $50 \Omega$
Solution
Simply add QW and Lpad attenuators to slotSetText_Zin()
