Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(builder): add test cases for action filter test based on standard schema #278

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mmackz
Copy link
Collaborator

@mmackz mmackz commented Mar 6, 2024

This PR introduces a standardized test for a valid transaction filter based on what is common amongst all transaction filters.

Why?: Currently someone making a plugin needs to manually implement a test for a valid action filter.

This method was very time consuming and did not add a lot of extra benefit over a standardized test.

@mmackz mmackz requested a review from a team as a code owner March 6, 2024 23:08
Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: e7ae483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rabbitholegg/create-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant