Merge pull request #42 from rabbitholegg/fix_delete

Fix(filters): copy vs delete
rabbitholegg · Oct 19, 2023 · 9a5fef8 · 9a5fef8
2 parents f829eed + 42cd83c
commit 9a5fef8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/.changeset/clever-candles-beg.md b/.changeset/clever-candles-beg.md
@@ -0,0 +1,5 @@
+---
+"@rabbitholegg/questdk": patch
+---
+
+Use shallow copies instead of true copies
diff --git a/src/filter/filters.ts b/src/filter/filters.ts
@@ -195,8 +195,8 @@ export const handleAbiDecode = (context: any, filter: AbiFilter) => {
       },
       {},
     )
-    delete (filter as FilterObject).$abi
-    if (apply({ ...namedArgs, sighash, functionName }, filter)) {
+    const { $abi: _, ...newFilter } = filter
+    if (apply({ ...namedArgs, sighash, functionName }, newFilter)) {
       return true
     }
     return null
@@ -212,7 +212,8 @@ export const handleAbstractAbiDecode = (
   const decodedReturn: ReturnType<typeof handleAbiDecode>[] = []
   const elementCount = filter.$abiAbstract!.length
   const $abiAbstract = filter.$abiAbstract
-  delete (filter as FilterObject).$abiAbstract
+  const { $abiAbstract: _, ...newFilter } = filter
+
   const contextMap = new Map<string, number>()
   // Function selectors are 4 bytes long - 8 characters
   for (let i = 2; i < context.length - 8; i++) {
@@ -228,7 +229,7 @@ export const handleAbstractAbiDecode = (
       if (index !== undefined) {
         decodedReturn.push(
           handleAbiDecode(`0x${context.substring(index)}`, {
-            ...filter,
+            ...newFilter,
             $abi: [abiItem],
           }),
         )
@@ -261,8 +262,8 @@ export const handleAbiParamDecode = (context: any, filter: AbiParamFilter) => {
       },
       {},
     )
-    delete (filter as FilterObject).$abiParams
-    if (apply(namedArgs, filter)) {
+    const { $abiParams: _, ...newFilter } = filter
+    if (apply(namedArgs, newFilter)) {
       return true
     }
     return null